jenkins-infra / uplink

A simple telemetry service for Jenkins instances.
https://uplink.jenkins.io/
GNU Affero General Public License v3.0
1 stars 2 forks source link

Switch the export controller to stream results directly from PostgreSQL to the response buffer #34

Closed rtyler closed 5 years ago

rtyler commented 5 years ago

I'm still not entirely sure if the PostgreSQL connection is being suitably returned to sequelize's connection pool, but I think this is an infrequent enough operation that it's worth deploying and monitoring of Sentry

Fixes #29, #33

jenkinsadmin commented 5 years ago

Build failed; the context from the latest run is:

Expand to view ``` The NODE_ENV variable is not set. Defaulting to a blank string. The DEBUG variable is not set. Defaulting to a blank string. The SENTRY_DSN variable is not set. Defaulting to a blank string. Starting infrauplinkpr34qfc37w263gvjff5jkpxk2d7tpmf4v6anzcbrzb2wam35yk3icg2q_db_1 ...  Starting infrauplinkpr34qfc37w263gvjff5jkpxk2d7tpmf4v6anzcbrzb2wam35yk3icg2q_db_1 ... done  Sequelize CLI [Node: 10.14.1, CLI: 4.1.1, ORM: 4.38.0] Loaded configuration file "config/database.js". Using environment "development". Thu, 06 Dec 2018 01:32:39 GMT sequelize deprecated String based operators are now deprecated. Please use Symbol based operators for better security, read more at http://docs.sequelizejs.com/manual/tutorial/querying.html#operators at node_modules/sequelize/lib/sequelize.js:242:13 File: .gitignore does not match pattern: /\.js$/ File: .gitignore does not match pattern: /\.js$/ File: .gitignore does not match pattern: /\.js$/ == 20180912042127-initial-admins: migrating ======= == 20180912042127-initial-admins: migrated (0.027s) == 20180920225942-specific-types: migrating ======= == 20180920225942-specific-types: migrated (0.016s) /mnt/agent-workspace/workspace/Infra_uplink_PR-34-QFC37W263GVJFF5JKPXK2D7TPMF4V6ANZCBRZB2WAM35YK3ICG2Q/node_modules/typescript/bin/tsc src/services/index.ts(1,18): error TS2307: Cannot find module './bulk'. Makefile:28: recipe for target 'build' failed make: *** [build] Error 2 [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Containers) Stage "Containers" skipped due to earlier failure(s) [Pipeline] } [Pipeline] // stage [Pipeline] stage [Pipeline] { (Publish container) Stage "Publish container" skipped due to earlier failure(s) [Pipeline] } [Pipeline] // stage [Pipeline] } [Pipeline] // timestamps [Pipeline] } [Pipeline] // timeout [Pipeline] } [Pipeline] // withEnv [Pipeline] } [Pipeline] // node [Pipeline] End of Pipeline GitHub has been notified of this commit’s build result ERROR: script returned exit code 2 Finished: FAILURE ```

Powered by the Comment Logger

rtyler commented 5 years ago

Might as well just ship this.