jenkins-infra / uplink

A simple telemetry service for Jenkins instances.
https://uplink.jenkins.io/
GNU Affero General Public License v3.0
1 stars 2 forks source link

Node 9 is specified in the Dockefile while the app is build from Node 10 in Makefile #48

Open lemeurherve opened 1 year ago

lemeurherve commented 1 year ago

Reproduction steps

  1. Notice the use of node 9 in the Dockerfile:
  2. Notice the use of node 10 in ./tools/node/:
  3. Notice the use of node 10 in the docker-compose file (not used in build, just FYI)
  4. check output of npm version in build logs (added in #47)
    { uplink: '1.0.0',
    npm: '6.14.12',
    ares: '1.15.0',
    brotli: '1.0.7',
    cldr: '35.1',
    http_parser: '2.9.4',
    icu: '64.2',
    modules: '64',
    napi: '7',
    nghttp2: '1.41.0',
    node: '10.24.1',
    openssl: '1.1.1k',
    tz: '2019c',
    unicode: '12.1',
    uv: '1.34.2',
    v8: '6.8.275.32-node.59',
    zlib: '1.2.11' }

Expected Results

Same version of node used in the Dockerfile and in the Makefile.

Actual Results

Mismatch between node versions used in Docerfile and in the Makefile.

Anything else?

No response