search

jenkins-infra / uplink

A simple telemetry service for Jenkins instances.
https://uplink.jenkins.io/
GNU Affero General Public License v3.0
1 stars 2 forks source link

fix: use `npm ci` instead of `npm install` #51

Closed lemeurherve closed 1 year ago

lemeurherve commented 1 year ago

This PR fixes #50 by using npm ci instead of npm install.

Doing so requires #49 (cherry-picked here), as npm ci has been release in version 5.7.0, while the last version of node9 image is published with npm version 5.6.0.

Commit to review: https://github.com/jenkins-infra/uplink/commit/a4d24ac1f97e32a389ba53f48a18474adeaa0737

Note: this build should fail the make migrate check step as the pg upgrade done in #41 won't be taken in account with npm ci.

I'll reopen #40, another PR will follow up with an updated package-lock.json to fix it again.

Cherry-picked #46 too to fix the following error:

Invalid: lock file's pg@7.4.3 does not satisfy pg@^8.7.1

lemeurherve commented 1 year ago

Superseded by #54