search

jenkins-infra / uplink

A simple telemetry service for Jenkins instances.
https://uplink.jenkins.io/
GNU Affero General Public License v3.0
1 stars 2 forks source link

fix: replace `npm install` by `npm ci` to get deterministic builds #54

Closed lemeurherve closed 1 year ago

lemeurherve commented 1 year ago

Fixes #50

lemeurherve commented 1 year ago

The pg upgrade from #41 and #52 appear to be needed even with npm ci:

https://infra.ci.jenkins.io/job/docker-jobs/job/uplink/view/change-requests/job/PR-54/2/console

Error: Unknown authenticationOk message typeMessage { name: 'authenticationOk', length: 23 }

dduportal commented 1 year ago

The pg upgrade from #41 and #52 appear to be needed even with npm ci:

https://infra.ci.jenkins.io/job/docker-jobs/job/uplink/view/change-requests/job/PR-54/2/console

Error: Unknown authenticationOk message typeMessage { name: 'authenticationOk', length: 23 }

@lemeurherve worth pinning the postgres major version to map to what we have in production. https://github.com/lemeurherve/uplink/blob/ec947d80e72f8b2355ce3e5c781bfb811515ac41/docker-compose.yml#L4 is using "latest available" so the error could be due to the DB version, WDYT?

lemeurherve commented 1 year ago

@lemeurherve worth pinning the postgres major version to map to what we have in production. https://github.com/lemeurherve/uplink/blob/ec947d80e72f8b2355ce3e5c781bfb811515ac41/docker-compose.yml#L4 is using "latest available" so the error could be due to the DB version, WDYT?

That was it, thanks!

Addressed in https://github.com/jenkins-infra/uplink/pull/54/commits/6eaf25e507b0a7ee2770f0f9907c2ece7cfb27af