search

jenkins-x-apps / jx-app-cheese

Sample app for Jenkins X
0 stars 4 forks source link

feat: add static web server #12

Closed pmuir closed 4 years ago

pmuir commented 5 years ago

/test this

pmuir commented 5 years ago

/test this

mwm-kube-cd-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: pmuir

If they are not already assigned, you can assign the PR to them by writing /assign @pmuir in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x-apps/jx-app-cheese/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mwm-kube-cd-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: pmuir

If they are not already assigned, you can assign the PR to them by writing /assign @pmuir in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x-apps/jx-app-cheese/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rawlingsj commented 5 years ago

/test this

pmuir commented 5 years ago

/approve

jstrachan commented 5 years ago

/lgtm

pmuir commented 5 years ago

/approve cancel

jenkins-x-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-apps/jx-app-cheese/blob/master/OWNERS)~~ [jstrachan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pmuir commented 5 years ago

/test this

jenkins-x-bot commented 5 years ago

@pmuir: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
serverless-jenkins cb6bcb470ad196fdc9e2d014379c9a03397f52e2 [link]() /test this
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).