search

jenkins-x-apps / jx-app-cheese

Sample app for Jenkins X
0 stars 4 forks source link

Tekton Buildpack #20

Closed warrenbailey closed 5 years ago

warrenbailey commented 5 years ago

Use the new tekton buildpack

jenkins-x-bot commented 5 years ago

Hi @warrenbailey. Thanks for your PR.

I'm waiting for a jenkins-x-apps member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
warrenbailey commented 5 years ago

Requires https://github.com/jenkins-x-buildpacks/jenkins-x-kubernetes/pull/32

warrenbailey commented 5 years ago

/test this

warrenbailey commented 5 years ago

/ok-to-test

warrenbailey commented 5 years ago

/test this

warrenbailey commented 5 years ago

/test this

jenkins-x-bot-test commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: jstrachan

If they are not already assigned, you can assign the PR to them by writing /assign @jstrachan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x-apps/jx-app-cheese/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
warrenbailey commented 5 years ago

/test this

warrenbailey commented 5 years ago

/lgtm

jenkins-x-bot commented 5 years ago

@warrenbailey: you cannot LGTM your own PR.

In response to [this](https://github.com/jenkins-x-apps/jx-app-cheese/pull/20#issuecomment-483255907): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
warrenbailey commented 5 years ago

/hold

warrenbailey commented 5 years ago

/lgtm

jenkins-x-bot commented 5 years ago

@warrenbailey: you cannot LGTM your own PR.

In response to [this](https://github.com/jenkins-x-apps/jx-app-cheese/pull/20#issuecomment-483264123): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
warrenbailey commented 5 years ago

/lgtm

jenkins-x-bot commented 5 years ago

@warrenbailey: you cannot LGTM your own PR.

In response to [this](https://github.com/jenkins-x-apps/jx-app-cheese/pull/20#issuecomment-483264947): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jstrachan commented 5 years ago

/lgtm

jenkins-x-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan, warrenbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-apps/jx-app-cheese/blob/master/OWNERS)~~ [jstrachan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
warrenbailey commented 5 years ago

/hold cancel