search

jenkins-x-buildpacks / jenkins-x-kubernetes

Kubernetes Build Pack extends the Classic Build Pack to add opinionated CI+CD for Kubernetes Environments with GitOps based promotion
Apache License 2.0
83 stars 266 forks source link

Set expose to false for default Helm chart values #76

Open CarpathianUA opened 4 years ago

CarpathianUA commented 4 years ago

Hi,

I guess it's much more convenient to have a fabric8.io/expose: "true" annotation set to false by default in all build packs. Usually during development people are not willing to expose a workload to the public internet. The case here is, for example, if I'm importing 20 projects with jx import, I'll need to go over 20 helm values.yaml and change an annotation to false...

Also an option for jx import, e.g. jx import --expose false|true will be also very useful!

Thanks!