env indented instead of key value - Githubissues

jenkins-x-buildpacks / jenkins-x-kubernetes

Kubernetes Build Pack extends the Classic Build Pack to add opinionated CI+CD for Kubernetes Environments with GitOps based promotion

Apache License 2.0

83 stars 268 forks source link

env indented instead of key value #99

Open yelhouti opened 4 years ago

yelhouti commented 4 years ago

https://github.com/jenkins-x-buildpacks/jenkins-x-kubernetes/blob/e8c3a3715a80a85d897aa1ffe87c00108d5910e6/packs/gradle/charts/templates/deployment.yaml#L33 instead of a simple env indent (the same way we do with envFrom) we use this fancy key:value that wasted my time more than anything else:

didn't work at first as expect since not standard...
can't use valueFrom to choose the name of my variables with a specific field in a secret...

Can we just switch it to a simple indent of what the user provided ?

thanks