jenkins-x-plugins / jx-gitops

a simple CLI tool for working with kubernetes resources files in a GitOps repository
Apache License 2.0
32 stars 50 forks source link

feat: support create/update deployment in remote cluster #920

Closed msvticket closed 1 year ago

msvticket commented 1 year ago

In remote cluster there won't be be any source configs. But in the common case where application repositories are in the same organisation as the cluster repository the work around of this PR should work.

To reduce the number of calls to the git provider (i.e. GitHub) only deployments for releases deployed that last 2 hours are updated.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

msvticket commented 1 year ago

/cc ankitm123 tomhobson babadofar

tomhobson commented 1 year ago

/cc @Skisocks

Can you have a review of this? You've been through this code a few times now so I think you're the best fit

Skisocks commented 1 year ago

/lgtm

jenkins-x-bot commented 1 year ago

@Skisocks: changing LGTM is restricted to collaborators

In response to [this](https://github.com/jenkins-x-plugins/jx-gitops/pull/920#issuecomment-1480929015): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
jenkins-x-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skisocks, tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-gitops/blob/main/OWNERS)~~ [tomhobson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jenkins-x-bot commented 1 year ago

Failed to merge this PR due to:

failed merging [920]: [Method Not Allowed]