jenkins-x-plugins / jx-gitops

a simple CLI tool for working with kubernetes resources files in a GitOps repository
Apache License 2.0
33 stars 50 forks source link

feat: allow override of the default container tool #921

Closed tomhobson closed 1 year ago

tomhobson commented 1 year ago

If you're using podman or something other than docker, you'll get the error

error: docker must be running to use this command
To install docker, follow the instructions at https://docs.docker.com/get-docker/.'

If you set the environmental flag detailed here: https://kpt.dev/reference/cli/fn/eval/?id=environment-variables then it will work.

Let's make it easier for users by passing it easily via a parameter.

tomhobson commented 1 year ago

/cc @babadofar @msvticket @ankitm123

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jenkins-x-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-gitops/blob/main/OWNERS)~~ [msvticket] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment