search

jenkins-x-plugins / jx-gitops

a simple CLI tool for working with kubernetes resources files in a GitOps repository
Apache License 2.0
32 stars 50 forks source link

fix: correct sign of offset and negation of expression #922

Closed msvticket closed 1 year ago

msvticket commented 1 year ago

Fix to make it work like intended in #920

msvticket commented 1 year ago

You are welcome to check as well @Skisocks

msvticket commented 1 year ago

/cc ankitm123 babadofar

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
38.2% 38.2% Duplication

jenkins-x-bot commented 1 year ago

Failed to merge this PR due to:

failed merging [922]: [Method Not Allowed]

jenkins-x-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Skisocks To complete the pull request process, please assign msvticket You can assign the PR to them by writing /assign @msvticket in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x-plugins/jx-gitops/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment