search

jenkins-x-plugins / jx-gitops

a simple CLI tool for working with kubernetes resources files in a GitOps repository
Apache License 2.0
32 stars 50 forks source link

small fixes for helmfile handling #929

Closed msvticket closed 1 year ago

msvticket commented 1 year ago

The fix to report solves the problem that lastDeployTime is updated on every execution of jx gitops helmfile report if you have several releases in the same namespace of the same chart, but different versions. The bug mainly causes problems with merge conflicts.

The change to status means that we avoid creating deployment in github for releases without lastDeployed. Since this also means that version is missing, which is caught later with a warning message, it essentially means that a warning log message is avoided.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jenkins-x-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-gitops/blob/main/OWNERS)~~ [tomhobson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jenkins-x-bot commented 1 year ago

Failed to merge this PR due to:

failed merging [929]: [Method Not Allowed]