Closed Skisocks closed 9 months ago
Hi @Skisocks. Thanks for your PR.
I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/cc @tomhobson @msvticket
/ok-to-test
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication
/cc @msvticket
/approve
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
Failed to merge this PR due to:
failed merging [939]: [Method Not Allowed]
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: msvticket
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Noticed issues with
jx gitops helmfile report
where namespaces were being reported twice. Seems thatGatherHelmfiles()
is both recursively finding a nested helmfile and appending it, but then also appending the same file by calculating it's location.Removing the calculation resolves the issue but highlighted another issue in
jx gitops helmfile resolve
where if both a "jx3" and "jenkins-x" repository were found then only one was removed. This has also been fixed.