jenkins-x-plugins / jx-gitops

a simple CLI tool for working with kubernetes resources files in a GitOps repository
Apache License 2.0
32 stars 50 forks source link

fix: issue with duplicate helmfiles being returned #939

Closed Skisocks closed 9 months ago

Skisocks commented 9 months ago

Noticed issues with jx gitops helmfile report where namespaces were being reported twice. Seems that GatherHelmfiles() is both recursively finding a nested helmfile and appending it, but then also appending the same file by calculating it's location.

Removing the calculation resolves the issue but highlighted another issue in jx gitops helmfile resolve where if both a "jx3" and "jenkins-x" repository were found then only one was removed. This has also been fixed.

jenkins-x-bot commented 9 months ago

Hi @Skisocks. Thanks for your PR.

I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
Skisocks commented 9 months ago

/cc @tomhobson @msvticket

msvticket commented 9 months ago

/ok-to-test

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Skisocks commented 9 months ago

/cc @msvticket

msvticket commented 9 months ago

/approve

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

Failed to merge this PR due to:

failed merging [939]: [Method Not Allowed]

jenkins-x-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-gitops/blob/main/OWNERS)~~ [msvticket] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment