search

jenkins-x-plugins / jx-gitops

a simple CLI tool for working with kubernetes resources files in a GitOps repository
Apache License 2.0
32 stars 50 forks source link

chore: upgrade helmfile to 0.149.0 #950

Closed joshuasimon-taulia closed 5 months ago

joshuasimon-taulia commented 5 months ago

v0.149.0 is the latest version which avoids the backwards-incompatible logic in https://github.com/helmfile/helmfile/pull/592, but contains the fix in https://github.com/helmfile/helmfile/pull/499 which unblocks me from using export HELMFILE_USE_SELECTORS = true in my bootjob Makefile.

jenkins-x-bot commented 5 months ago

Hi @joshuasimon-taulia. Thanks for your PR.

I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

joshuasimon-taulia commented 5 months ago

/assign @msvticket

msvticket commented 5 months ago

/ok-to-test

msvticket commented 5 months ago

/approve

jenkins-x-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-gitops/blob/main/OWNERS)~~ [msvticket] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
joshuasimon-taulia commented 5 months ago

thank you!