search

jenkins-x-plugins / jx-gitops

a simple CLI tool for working with kubernetes resources files in a GitOps repository
Apache License 2.0
33 stars 51 forks source link

chore: use go 1.22 #961

Closed JordanGoasdoue closed 6 months ago

JordanGoasdoue commented 6 months ago

related to https://github.com/jenkins-x/jx/pull/8663

jenkins-x-bot commented 6 months ago

Hi @JordanGoasdoue. Thanks for your PR.

I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
msvticket commented 6 months ago

/ok-to-test

msvticket commented 6 months ago

@JordanGoasdoue Well, that unfortunately failed. You can see the result of CodeQL / Analyze (go) (pull_request) yourself.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

JordanGoasdoue commented 6 months ago

indeed @msvticket I was looking about it

seems to be fixed with this commit

Now let see if everything is :white_check_mark: :crossed_fingers:

jenkins-x-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-gitops/blob/main/OWNERS)~~ [msvticket] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jenkins-x-bot commented 6 months ago

Failed to merge this PR due to:

failed merging [961]: [Method Not Allowed]