Closed GavinPJK closed 1 week ago
/cc @msvticket
Hi @GavinPJK. Thanks for your PR.
I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/retest
/retest
@GavinPJK It's the same here: rebase on main. In this case so the lint pipeline will run.
@GavinPJK You should also verify that make test
succeeds after the rebase
Failed conditions
85.7% Duplication on New Code (required ≤ 3%)
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: msvticket
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Failed to merge this PR due to:
failed merging [973]: [Method Not Allowed]
Use
PartialCloneClusterRepo
(from following addition tojx-helpers
- https://github.com/jenkins-x/jx-helpers/pull/420) to attempt sparse and partial clone of the upstream cluster repository, as only the.jx/gitops/source-config.yaml
file is required when finding requirements withvariablefinders
.This change impacts the speed of
jx gitops helm release
andjx gitops variables
commands when the upstream git provider supportsgit-sparse-checkout
, in addition to the--filter=blob:none
and--depth=1
flags. Falls back to a full clone if neither are supported.Picking a real example that is used for the following
jx-variables
pipeline task step - https://github.com/jenkins-x/jx3-pipeline-catalog/blob/b14ab0afd073539a25e5f2cee342f1e99537b46a/tasks/csharp/pullrequest.yaml#L27-L36:Before (step duration = 1m 16s):
After (step duration = 8s):