jenkins-x-plugins / jx-pipeline

a small binary plugin for working with Jenkins X pipelines
Apache License 2.0
8 stars 25 forks source link

fix: Using pager for logs #497

Closed msvticket closed 2 years ago

msvticket commented 2 years ago

The introduction of setOutput made the input to the pager close before the logs where output to it. This fixes that

Also doing some wording fixes while at it

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

msvticket commented 2 years ago

/cc ankitm123

codecov[bot] commented 2 years ago

Codecov Report

Base: 37.24% // Head: 37.61% // Increases project coverage by +0.36% :tada:

Coverage data is based on head (2208b21) compared to base (55287b5). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #497 +/- ## ========================================== + Coverage 37.24% 37.61% +0.36% ========================================== Files 44 44 Lines 5912 5950 +38 ========================================== + Hits 2202 2238 +36 - Misses 3369 3371 +2 Partials 341 341 ``` | [Impacted Files](https://codecov.io/gh/jenkins-x-plugins/jx-pipeline/pull/497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins) | Coverage Δ | | |---|---|---| | [pkg/cmd/getlog/logs.go](https://codecov.io/gh/jenkins-x-plugins/jx-pipeline/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins#diff-cGtnL2NtZC9nZXRsb2cvbG9ncy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/cmd/getlog/tekton\_logs.go](https://codecov.io/gh/jenkins-x-plugins/jx-pipeline/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins#diff-cGtnL2NtZC9nZXRsb2cvdGVrdG9uX2xvZ3MuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/cmd/lint/lint.go](https://codecov.io/gh/jenkins-x-plugins/jx-pipeline/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins#diff-cGtnL2NtZC9saW50L2xpbnQuZ28=) | `48.81% <0.00%> (ø)` | | | [pkg/lighthouses/pipelines.go](https://codecov.io/gh/jenkins-x-plugins/jx-pipeline/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins#diff-cGtnL2xpZ2h0aG91c2VzL3BpcGVsaW5lcy5nbw==) | `40.00% <0.00%> (ø)` | | | [pkg/pipelines/processor/helpers.go](https://codecov.io/gh/jenkins-x-plugins/jx-pipeline/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins#diff-cGtnL3BpcGVsaW5lcy9wcm9jZXNzb3IvaGVscGVycy5nbw==) | `45.65% <0.00%> (ø)` | | | [pkg/pipelines/pipelines.go](https://codecov.io/gh/jenkins-x-plugins/jx-pipeline/pull/497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins#diff-cGtnL3BpcGVsaW5lcy9waXBlbGluZXMuZ28=) | `79.20% <0.00%> (+2.57%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

msvticket commented 2 years ago

/approve

jenkins-x-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-pipeline/blob/main/OWNERS)~~ [msvticket] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment