fixed argument configureOpts to return git credentials to gitFactory

[KiranSatyaRaj]

Signed-off-by: Kiran Satya Raj kiranjamy20021508@gmail.com fixes jenkins-x/jx#8421

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[jenkins-x-bot]

Hi @KiranSatyaRaj. Thanks for your PR.

I'm waiting for a jenkins-x-plugins or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign ankitm123 You can assign the PR to them by writing /assign @ankitm123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x-plugins/jx-pipeline/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[KiranSatyaRaj]

/assign @ankitm123

[msvticket]

/ok-to-test

[jenkins-x-bot]

@KiranSatyaRaj: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
lint	655965ce0b8b169e3d4eab8856718966bf56c53b	link	/test lint

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[codecov[bot]]

Codecov Report

Base: 37.36% // Head: 37.31% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (655965c) compared to base (a091446). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #509 +/- ## ========================================== - Coverage 37.36% 37.31% -0.05% ========================================== Files 44 44 Lines 5947 5954 +7 ========================================== Hits 2222 2222 - Misses 3382 3389 +7 Partials 343 343 ``` | [Impacted Files](https://codecov.io/gh/jenkins-x-plugins/jx-pipeline/pull/509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins) | Coverage Δ | | |---|---|---| | [pkg/cmd/start/start.go](https://codecov.io/gh/jenkins-x-plugins/jx-pipeline/pull/509/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins#diff-cGtnL2NtZC9zdGFydC9zdGFydC5nbw==) | `62.56% <0.00%> (-1.08%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jenkins-x-plugins)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[KiranSatyaRaj]

@msvticket there are a few test cases failing when I ran make lint Error: -//nolint +// nolint func (p *inliner) processTaskSpec(ts *v1beta1.TaskSpec, path, name string) (bool, error) { templateImage := "" if ts.StepTemplate != nil { make: *** [Makefile:170: lint] Error 1

[msvticket]

This is the output of the linter:

cmd/docs/main.go:7: File is not `gofmt`-ed with `-s` (gofmt)
//     http://www.apache.org/licenses/LICENSE-2.0
cmd/docs/md_docs.go:7: File is not `gofmt`-ed with `-s` (gofmt)
//     http://www.apache.org/licenses/LICENSE-2.0
pkg/cmd/effective/effective.go:4:2: SA1019: "io/ioutil" has been deprecated since Go 1.16: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
    "io/ioutil"
    ^

[KiranSatyaRaj]

hey @msvticket, make lint gave me an output to install golangci-lint v1.46.2 just that, I currently have v1.50.1, so should it be update then

[KiranSatyaRaj]

hey @msvticket, make lint gave me an output to install golangci-lint v1.46.2 just that, I currently have v1.50.1, so should it be update then

hey @msvticket can we discuss this if you're available?

[msvticket]

hey @msvticket, make lint gave me an output to install golangci-lint v1.46.2 just that, I currently have v1.50.1, so should it be update then

I suspect that if you have a newer lint you will find more problems. But what you have to fix are the issues that the lint pipeline finds

[KiranSatyaRaj]

hey @msvticket, make lint gave me an output to install golangci-lint v1.46.2 just that, I currently have v1.50.1, so should it be update then

I suspect that if you have a newer lint you will find more problems. But what you have to fix are the issues that the lint pipeline finds

I've installed the 1.46.2 version of golangci-lint(current version for jx-pipilne), I got a few warns on bodyclose, rowserrcheck, structcheck, unparam are disabled because of go1.18 and an error pkg/cmd/effective/effective.go:4:2: SA1019: package io/ioutil is deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck) "io/ioutil" so all the functions from io/ioutil should be replaced by equivalent functions from io or os packages, right?

[msvticket]

@KiranSatyaRaj Why don't you just fix the lint issues in https://github.com/jenkins-x-plugins/jx-pipeline/pull/509#issuecomment-1339730987 ?

[KiranSatyaRaj]

hey @msvticket, can you please let me know the command you used to perform lint because I get an output different from #509 (comment) when I execute make lint