Closed Skisocks closed 1 year ago
Hi @Skisocks. Thanks for your PR.
I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/cc @tomhobson @msvticket
/ok-to-test
level=warning msg="[linters_context] rowserrcheck is disabled because of generics. You can track the evolution of the generics support by following the [https://github.com/golangci/golangci-lint/issues/2649."](https://github.com/golangci/golangci-lint/issues/2649.)
pkg/pipelines/processor/gitref.go:20:7: hugeParam: g is heavy (81 bytes); consider passing it by pointer (gocritic)
func (g GitRef) IsEmpty() bool {
^
pkg/pipelines/processor/gitref.go:25:7: hugeParam: g is heavy (81 bytes); consider passing it by pointer (gocritic)
func (g GitRef) GetParentFileName() string {
^
pkg/pipelines/processor/gitref.go:31:7: hugeParam: g is heavy (81 bytes); consider passing it by pointer (gocritic)
func (g GitRef) ToParams() []v1beta1.Param {
^
pkg/pipelines/processor/gitref.go:69:7: hugeParam: g is heavy (81 bytes); consider passing it by pointer (gocritic)
func (g GitRef) ToResolverRef() v1beta1.ResolverRef {
^
pkg/pipelines/processor/remotetasks_migrator.go:324:70: hugeParam: ref is heavy (81 bytes); consider passing it by pointer (gocritic)
func (p *RemoteTasksMigrator) pipelineTaskFromParentRef(name string, ref GitRef) v1beta1.PipelineTask {
^
pkg/pipelines/processor/gitref.go:4: File is not `goimports`-ed (goimports)
"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
pkg/pipelines/processor/gitresolverref.go:6: File is not `goimports`-ed (goimports)
"github.com/jenkins-x/jx-helpers/v3/pkg/gitclient/giturl"
pkg/pipelines/processor/gitresolverref.go:69:45: var-naming: method parameter cloneUrl should be cloneURL (revive)
func (g *GitRefResolver) isRepositoryPublic(cloneUrl string) (bool, error) {
^
pkg/pipelines/processor/gitresolverref.go:75:24: response body must be closed (bodyclose)
resp, err := client.Do(req)
^
pkg/pipelines/processor/remotetasks_migrator.go:301:10: shadow: declaration of "err" shadows declaration at line 290 (govet)
task, err := p.NewTaskFromStepAndPipelineRun(step, prs, true)
^
Kudos, SonarCloud Quality Gate passed!
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: tomhobson
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The Tekton git resolver uses different params for public/private repositories. This PR allows the migration tool to check if a repo is public then sets the gitRef params accordingly.