chore: make jx pipeline work with params & results

jenkins-x-plugins / jx-pipeline

a small binary plugin for working with Jenkins X pipelines

Apache License 2.0

8 stars 25 forks source link

chore: make jx pipeline work with params & results #527

Closed JordanGoasdoue closed 1 year ago

JordanGoasdoue commented 1 year ago

Fix this kind of error I have with the latest jx 3.10.96, by using the latest lighthouse-client v0.0.929

failed to validate generated PipelineRun: invalid value: expected pipeline results to be task result expressions but an invalid expressions was found: spec.pipelineSpec.results[0].value
invalid value: expected pipeline results to be task result expressions but no expressions were found: spec.pipelineSpec.results[0].value

jenkins-x-bot commented 1 year ago

Hi @JordanGoasdoue. Thanks for your PR.

I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.

jenkins-x-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-pipeline/blob/main/OWNERS)~~ [tomhobson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment