search

jenkins-x-plugins / jx-pipeline

a small binary plugin for working with Jenkins X pipelines
Apache License 2.0
8 stars 25 forks source link

chore: upgrade go to 1.22 #542

Closed msvticket closed 4 months ago

msvticket commented 4 months ago

fixing issues with upgraded lint removing use of github.com/pkg/errors

related to jenkins-x/jx#8670

msvticket commented 4 months ago

/test pr

msvticket commented 4 months ago

/test lint

msvticket commented 4 months ago

/retest

msvticket commented 4 months ago

/retest

msvticket commented 4 months ago

/retest

msvticket commented 4 months ago

/test pr

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 2.94906% with 362 lines in your changes missing coverage. Please review.

Project coverage is 40.59%. Comparing base (bfd1671) to head (d0330bd).

Files Patch % Lines
pkg/cmd/env/env.go 0.00% 31 Missing and 1 partial :warning:
pkg/cmd/start/start.go 9.67% 27 Missing and 1 partial :warning:
pkg/cmd/effective/effective.go 0.00% 24 Missing and 1 partial :warning:
pkg/cmd/importcmd/import.go 0.00% 24 Missing and 1 partial :warning:
pkg/cmd/convert/convert_uses.go 0.00% 23 Missing and 1 partial :warning:
pkg/cmd/fmt/fmt.go 0.00% 15 Missing :warning:
pkg/cmd/grid/grid.go 0.00% 15 Missing :warning:
pkg/cmd/breakpoint/breakpoint.go 0.00% 12 Missing and 1 partial :warning:
pkg/cmd/lint/lint.go 0.00% 12 Missing and 1 partial :warning:
pkg/tektonlog/tektonlog.go 0.00% 13 Missing :warning:
... and 30 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #542 +/- ## ========================================== + Coverage 39.18% 40.59% +1.41% ========================================== Files 49 49 Lines 6403 5190 -1213 ========================================== - Hits 2509 2107 -402 + Misses 3531 2720 -811 Partials 363 363 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
12.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

msvticket commented 4 months ago

/cc tomhobson JordanGoasdoue Skisocks

jenkins-x-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JordanGoasdoue

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-pipeline/blob/main/OWNERS)~~ [JordanGoasdoue] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment