jenkins-x-plugins / jx-secret

a binary plugin for working with Kubernetes External Secrets
Apache License 2.0
17 stars 24 forks source link

jx secret overrides secrets breaking everything when using vault #334

Open yelhouti opened 3 years ago

yelhouti commented 3 years ago

It seems like jx secret convert or populate in the jx3-kubernetes repo overrides all the secrets breaking existing running applications. This should be fixed asap IMO. Workaround: For now I create external-secrets manually ask my charts to use existing secret

yelhouti commented 3 years ago

After some luck and investigation, the issue about secrets disappearing and recreated seems to come when both local-external-secret and k8s external-secret both install the same (name)/different(content?) CRD. All external-secrets are deleted and with them there secrets. Then install creates/apply secret creates external-secrets from them then squashes the vault I think. IMO the squashing should never happen. Even if the secret is not present. This clearly needs some more investigation