search

jenkins-x-plugins / jx-secret

a binary plugin for working with Kubernetes External Secrets
Apache License 2.0
17 stars 24 forks source link

chore: Upgrade dependency on github.com/jenkins-x/jx-api/v4 #367

Closed msvticket closed 2 years ago

msvticket commented 2 years ago

Also ran go mod tidy Fixes that jx secret removes issueProvider from jx-requirements.yaml

jenkins-x-bot commented 2 years ago

Hi @msvticket. Thanks for your PR.

I'm waiting for a jenkins-x-plugins or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rawlingsj commented 2 years ago

/ok-to-test /lgtm

jenkins-x-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-secret/blob/main/OWNERS)~~ [rawlingsj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ankitm123 commented 2 years ago

/hold

ankitm123 commented 2 years ago

Just ran go mod tidy on main branch, and did not remove anything ... which version of go are you on @msvticket? I am on go version go1.15.6 linux/amd64

msvticket commented 2 years ago

I have 1.17.2.

ankitm123 commented 2 years ago

can you downgrade to 1.15 (or use gvm to switch the version)? I have a few PRs open to upgrade to 1.17 soon though ...

ankitm123 commented 2 years ago

/hold cancel