search

jenkins-x-plugins / jx-secret

a binary plugin for working with Kubernetes External Secrets
Apache License 2.0
17 stars 24 forks source link

jx secret mapping file should set region for AWS secrets manager #369

Closed ankitm123 closed 2 years ago

ankitm123 commented 2 years ago

jx secret populate fails for ASM with the message:

Error: failed to populate secrets: failed to save properties key: jx-admin-user properties: password, username on ExternalSecret jenkins-x-chartmuseum: error creating new secret for aws secret manager: : MissingRegion: could not find region configuration

The workaround is to set the region in the default section of the secret mapping file: https://github.com/jx3-gitops-repositories/jx3-eks-asm/blob/69a957feca79da5992fb81792b1849758d81f351/.jx/secret/mapping/secret-mappings.yaml#L4

Instead we want jx to populate the region from the requirements file.

Related to https://github.com/jenkins-x/jx/issues/7941

ankitm123 commented 2 years ago

/assign