search

jenkins-x-plugins / jx-secret

a binary plugin for working with Kubernetes External Secrets
Apache License 2.0
17 stars 24 forks source link

fix: get region for asm secrets from requirements file #370

Closed ankitm123 closed 2 years ago

ankitm123 commented 2 years ago

Signed-off-by: ankitm123 ankitmohapatra123@gmail.com

fixes #369

ankitm123 commented 2 years ago

/override SonarCloud Code Analysis

The reason for sonarcloud analysis error is that the test_data was renamed to testdata. So the dummy passwords used for testing flagged it.

jenkins-x-bot commented 2 years ago

@ankitm123: ankitm123 unauthorized: /override is restricted to repo administrators

In response to [this](https://github.com/jenkins-x-plugins/jx-secret/pull/370#issuecomment-997216875): >/override SonarCloud Code Analysis > >The reason for sonarcloud analysis error is that the test_data was renamed to testdata. So the dummy passwords used for testing flagged it. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
ankitm123 commented 2 years ago

/cc @rawlingsj

ankitm123 commented 2 years ago

/hold

ankitm123 commented 2 years ago

/hold cancel

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

rawlingsj commented 2 years ago

/lgtm

jenkins-x-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-secret/blob/main/OWNERS)~~ [rawlingsj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment