Closed Juneezee closed 2 years ago
Hi @Juneezee. Thanks for your PR.
I'm waiting for a jenkins-x-plugins or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
/ok-to-test /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ankitm123
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Follow up PR for https://github.com/jenkins-x-plugins/jx-gitops/pull/839#issuecomment-1079479757. This PR replaces
ioutil.TempDir
witht.TempDir
in tests.We can use the
T.TempDir
function from thetesting
package to create temporary directory. The directory created byT.TempDir
is automatically removed when the test and all its subtests complete.Reference: https://pkg.go.dev/testing#T.TempDir