Closed chrislovecnm closed 2 years ago
Hi @chrislovecnm. Thanks for your PR.
I'm waiting for a jenkins-x-plugins or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Kudos, SonarCloud Quality Gate passed!
/assign @ankitm123
/ok-to-test /lgtm
wont build arm binary for mac though I think ... but still good to have the makefile target ... /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ankitm123, tomhobson
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Adding the make target to build on the m1 mac.