search

jenkins-x-plugins / jx-secret

a binary plugin for working with Kubernetes External Secrets
Apache License 2.0
17 stars 24 forks source link

feat: deprecate KES and support ESO #387

Open ankitm123 opened 1 year ago

ankitm123 commented 1 year ago

Signed-off-by: ankitm123 ankitmohapatra123@gmail.com

jenkins-x-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign ankitm123 You can assign the PR to them by writing /assign @ankitm123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x-plugins/jx-secret/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

ankitm123 commented 1 year ago

jx secret populate works with both ESO and KES, but jx secret convert needs to be fixed. Still a work in progress, needs tests as well!

ankitm123 commented 1 year ago

/hold

jenkins-x-bot commented 1 year ago

@ankitm123: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pr f322396dec441ffb8320ca128fddd9ceeb891692 link /test pr
lint f322396dec441ffb8320ca128fddd9ceeb891692 link /test lint
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).