Open tomhobson opened 1 year ago
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
/cc @msvticket
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Skisocks
To complete the pull request process, please assign tomhobson
You can assign the PR to them by writing /assign @tomhobson
in a comment when ready.
The full list of commands accepted by this bot can be found here.
I'll have a first look now and will continue next week.
I'll begin with firing a question: How have you tested this so far?
To get the schema right it might be easiest to import github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1 and use the structures defined in https://github.com/external-secrets/external-secrets/blob/main/apis/externalsecrets/v1beta1/externalsecret_types.go
Removing backwards compatability, as we'll promote this change with the ESO migration