search

jenkins-x-plugins / jx-secret

a binary plugin for working with Kubernetes External Secrets
Apache License 2.0
17 stars 24 forks source link

fix: start migration to eso #397

Open tomhobson opened 1 year ago

tomhobson commented 1 year ago

Removing backwards compatability, as we'll promote this change with the ESO migration

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

tomhobson commented 5 months ago

/cc @msvticket

jenkins-x-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Skisocks To complete the pull request process, please assign tomhobson You can assign the PR to them by writing /assign @tomhobson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x-plugins/jx-secret/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msvticket commented 5 months ago

I'll have a first look now and will continue next week.

I'll begin with firing a question: How have you tested this so far?

msvticket commented 5 months ago

To get the schema right it might be easiest to import github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1 and use the structures defined in https://github.com/external-secrets/external-secrets/blob/main/apis/externalsecrets/v1beta1/externalsecret_types.go