jenkins-x-plugins / jx-slack

A Jenkins X plugin for receiving Slack notifications about pipeline events
Apache License 2.0
11 stars 16 forks source link

add unit test coverage and tests! #16

Open rawlingsj opened 4 years ago

rawlingsj commented 4 years ago

When the slack bot was made open source it came with no tests from its original source and so is very hard to make changes, understand what is meant to happen or what may be incorrect.

We should add test coverage and unit / integration tests, at the time of creating this issue we've started to add some but there is a long way to go. Not sure when we can say this issue can be closed, maybe once we get 50% coverage or something?

jenkins-x-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://jenkins-x.io/community. /lifecycle stale

rawlingsj commented 3 years ago

/remove-lifecycle stale

jenkins-x-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://jenkins-x.io/community. /lifecycle stale

jenkins-x-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://jenkins-x.io/community. /lifecycle rotten