Closed vbehar closed 3 years ago
Hi @vbehar. Thanks for your PR.
I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/assign @rawlingsj
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rawlingsj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@rawlingsj are you a bot? ;-) thanks!
Maybe ;)
I think we're missing an /ok-to-test
command to remove the needs-ok-to-test
label
@rawlingsj can you please add an /ok-to-test
comment to unblock lighthouse? thanks!
sorry yeah I was on my phone before doing the review /ok-to-test
since #25 we need to get the tide deployment, and the app won't start if it doesn't have the permissions