jenkins-x-plugins / jx-slack

A Jenkins X plugin for receiving Slack notifications about pipeline events
Apache License 2.0
11 stars 16 forks source link

fix: missing role permissions for deployments #26

Closed vbehar closed 3 years ago

vbehar commented 3 years ago

since #25 we need to get the tide deployment, and the app won't start if it doesn't have the permissions

jenkins-x-bot-test commented 3 years ago

Hi @vbehar. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
vbehar commented 3 years ago

/assign @rawlingsj

rawlingsj commented 3 years ago

/lgtm

jenkins-x-bot-test commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com#issuecomment-701943747/jenkins-x/slack/blob/master/OWNERS)~~ [rawlingsj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vbehar commented 3 years ago

@rawlingsj are you a bot? ;-) thanks!

rawlingsj commented 3 years ago

Maybe ;)

vbehar commented 3 years ago

I think we're missing an /ok-to-test command to remove the needs-ok-to-test label

vbehar commented 3 years ago

@rawlingsj can you please add an /ok-to-test comment to unblock lighthouse? thanks!

rawlingsj commented 3 years ago

sorry yeah I was on my phone before doing the review /ok-to-test