search

jenkins-x-plugins / jx-slack

A Jenkins X plugin for receiving Slack notifications about pipeline events
Apache License 2.0
11 stars 16 forks source link

Attempt using labels for jx 3 pipeline activities #34

Closed rishka closed 3 years ago

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jenkins-x-bot-test commented 3 years ago

Hi @rishka. Thanks for your PR.

I'm waiting for a jenkins-x-plugins or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
jstrachan commented 3 years ago

/ok-to-test /lgtm

jenkins-x-bot-test commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-slack/blob/main/OWNERS)~~ [jstrachan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jstrachan commented 3 years ago

I guess we could always modify the code to list all activities and look for either format?

rishka commented 3 years ago

I guess we could always modify the code to list all activities and look for either format?

Yea, its possible. I am going to work with this some more, as it unfortunately doesn't fix anything other than the error message in logs.

I do kind of wonder if it should just be versioned, base it on lighthouse-version or something

jstrachan commented 3 years ago

this PR tries to be more label agnostic: https://github.com/jenkins-x-plugins/jx-slack/pull/35

rishka commented 3 years ago

this PR tries to be more label agnostic: #35

Tried it out, looks like it works on my side, closing this one