search

jenkins-x-plugins / jx-slack

A Jenkins X plugin for receiving Slack notifications about pipeline events
Apache License 2.0
11 stars 16 forks source link

fix compatibility with bitbucketcloud #41

Closed TarekAS closed 2 years ago

TarekAS commented 2 years ago

In order to use this chart with bitbucketcloud, one must provide GIT_USER environment variable. Here we're using the pipeline user as that user.

Fixes the following error:

error: failed to validate options: failed to create SCM client: no username supplied
using driver: bitbucketcloud and serverURL:
jenkins-x-bot commented 2 years ago

Hi @TarekAS. Thanks for your PR.

I'm waiting for a jenkins-x-plugins or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ankitm123 commented 2 years ago

/ok-to-test /lgtm

ankitm123 commented 2 years ago

/cc @rawlingsj

rawlingsj commented 2 years ago

/lgtm

jenkins-x-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitm123, rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x-plugins/jx-slack/blob/main/OWNERS)~~ [rawlingsj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment