Closed wowq closed 1 year ago
Hi @wowq. Thanks for your PR.
I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/assign @babadofar
/ok-to-test
/approve
The test failed:
FAIL: TestModifyApplicationFiles (0.05s)
applications_test.go:19: using dir /tmp/TestModifyApplicationFiles1492847697/001
files.go:84:
Error Trace: /workspace/source/pkg/cmd/argo/promote/files.go:84
/workspace/source/pkg/cmd/argo/promote/applications_test.go:52
Error: Not equal:
expected: "apiVersion: argoproj.io/v1alpha1\nkind: ApplicationSet\nmetadata:\n name: my-v3-lts-node\n namespace: argocd\n annotations:\n gitops.jenkins-x.io/sourceRepoUrl: [https://github.com/myorg/myrepo.git\nspec:\n](https://github.com/myorg/myrepo.git/nspec:/n) generators:\n - clusters: {}\n template:\n metadata:\n name: \"{{name}}-my-v3-lts-node\"\n annotations:\n test1: test1\n spec:\n destination:\n namespace: cheese\n server: [https://kubernetes.default.svc\n](https://kubernetes.default.svc/n) project: default\n source:\n path: charts/my-chart\n repoURL: [https://github.com/myorg/myrepo.git\n](https://github.com/myorg/myrepo.git/n) targetRevision: v1.2.3\n syncPolicy:\n automated:\n selfHeal: true\n syncOptions:\n - CreateNamespace=true\n"
actual : "apiVersion: argoproj.io/v1alpha1\nkind: ApplicationSet\nmetadata:\n name: my-v3-lts-node\n namespace: argocd\n annotations:\n gitops.jenkins-x.io/sourceRepoUrl: [https://github.com/myorg/myrepo.git\nspec:\n](https://github.com/myorg/myrepo.git/nspec:/n) generators:\n - clusters: {}\n template:\n metadata:\n name: \"{{name}}-my-v3-lts-node\"\n annotations:\n test1: test1\n spec:\n destination:\n namespace: cheese\n server: {? {server: ''} : ''}\n project: default\n source:\n path: charts/my-chart\n repoURL: [https://github.com/myorg/myrepo.git\n](https://github.com/myorg/myrepo.git/n) targetRevision: v1.2.3\n syncPolicy:\n automated:\n selfHeal: true\n syncOptions:\n - CreateNamespace=true\n"
Diff:
--- Expected
+++ Actual
@@ -18,3 +18,3 @@
namespace: cheese
- server: https://kubernetes.default.svc/
+ server: {? {server: ''} : ''}
project: default
Test: TestModifyApplicationFiles
Messages: comparing text content of files /tmp/TestModifyApplicationFiles1492847697/001/simple/expected/myapp-appset.yaml and /tmp/TestModifyApplicationFiles1492847697/001/simple/source/myapp-appset.yaml
FAIL github.com/jenkins-x-plugins/jx-updatebot/pkg/cmd/argo/promote 0.211s
/approve cancel
Kudos, SonarCloud Quality Gate passed!
@msvticket fixed
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: msvticket
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Support update argo applicationset version