search

jenkins-x / draft-packs

Note these build packs are moving to https://github.com/jenkins-x-buildpacks
https://jenkins-x.io/architecture/build-packs/
Apache License 2.0
18 stars 45 forks source link

added support for service labels in helm chart #66

Closed wenzlaff closed 6 years ago

wenzlaff commented 6 years ago

The reason for creating this PR was to add more flexibility in configuring Helm Charts.

Having the possibility to add labels to the Services seems to be very useful in many cases, for example in selecting Services for Prometheus monitoring by their label.

After applying this PR, extensions to the values.xml in quickstart projects will lead to the following chart:

values.xml

service:
  labels:
    system: my-system
    testLabel: test

Service:

apiVersion: v1
kind: Service
metadata:
  labels:
    chart: my-chart-0.0.7
    system: my-system
    testLabel: test
jstrachan commented 6 years ago

@wenzlaff lovely stuff thanks!