search

jenkins-x / draft-packs

Note these build packs are moving to https://github.com/jenkins-x-buildpacks
https://jenkins-x.io/architecture/build-packs/
Apache License 2.0
18 stars 45 forks source link

Use docker registry repo instead of org #72

Closed dashford closed 6 years ago

dashford commented 6 years ago

Tied to changes in 1612 jenkins-x/jx.

As part of the above PR, the docker registry organisation can be specified when using the jx import command. In order for that to work the draft packs need to be updated with the new variable to set.

These contain breaking changes that rely on a version of jx containing the above PR. Chatting to James on slack he mentioned that the draft packs used by jx reference a branch of this repo so let me know if I need to merge into a branch different to master.

dashford commented 6 years ago

Hey @rawlingsj, @jstrachan,

Would you be able to advise on how I can get this merged? I don't think it can go into the 2.1 branch as it relies on a version of jx higher than 1.3.237 unless you think that version is widespread enough by now :smiley:

Thanks!

jstrachan commented 6 years ago

@dashford I've just created a 2.2 branch - wanna recreate this PR against the 2.2 branch rather than master? Then we can safely merge your change and update jx to reference the new 2.2 branch: https://github.com/jenkins-x/jx/blob/f16050c946426ab55b37b7b52a4fbd08108e2091/pkg/jx/cmd/common_team_settings.go#L26

dashford commented 6 years ago

Thanks @jstrachan, I've opened a new PR here against the 2.2 branch.