jenkins-x / draft-packs

Note these build packs are moving to https://github.com/jenkins-x-buildpacks
https://jenkins-x.io/architecture/build-packs/
Apache License 2.0
18 stars 45 forks source link

Always pass --batch-mode to jx preview from a Jenkinsfile #82

Closed jglick closed 6 years ago

jglick commented 6 years ago

@pmuir says there was recently a fix for

error: cannot create Git provider EOF

which is at least clearer when you are in the batch mode so you get

error: cannot create Git provider Running in batch mode and no default Git username found

There is no reason for a sh step in a build to be waiting for input!

rawlingsj commented 6 years ago

@markawm is this related to a fix you did today https://github.com/jenkins-x/jx/pull/2178, wonder if this is still needed?

jglick commented 6 years ago

https://github.com/jenkins-x/jx/pull/2178 sounds like the better fix indeed.

rawlingsj commented 6 years ago

ok great, closing this one