search

jenkins-x / enhancements

Repository containing design proposals for Jenkins X enhancements
12 stars 16 forks source link

feat: adding proposal #3 - cloud resource creation #13

Closed hferentschik closed 4 years ago

polothy commented 4 years ago

Proposal looks good to me 💯

My only feedback is make sure a very detailed change log goes along with this new terraform project incase someone needs to fork or port it to another system. That way, when we come back in 6months we are not lost on what has changed.

hferentschik commented 4 years ago

@polothy, thanks for reviewing and the feedback. Docs are imo key here. Part of this change for me is to have a clear understanding of what Jenkins X requires in terms of (cloud) resources.

hferentschik commented 4 years ago

Ok, so after some long discussion with @daveconde and @dgozalo we decided we will split out any changes on how we integrate with Vault from this enhancement.

I think there was a misunderstanding about what I was proposing when it comes to Vault. This enhancement proposed to move away from the usage of the Vault Operator from within jx boot.

The idea was to address Vault related issues at the same time as the pure cloud resource creation. Given that this is really an orthogonal problem it should probably be handled separately.

@daveconde and @dgozalo convinced me that it would be better to purely focus on cloud resource creation via Terraform for now.

I'll update the proposal asap.

ethangj commented 4 years ago

When we get to the working POC stage of this work, I have a survey created I'd like to use to get some community feedback in as soon as it's viable.

hferentschik commented 4 years ago

Pushed an update with a much smaller scope. All changes to the Vault setup are removed and will become of a separate issue. Now we are just dealing with a proposal of using Terraform to handle cloud resource extraction.

hferentschik commented 4 years ago

Going to merge this after we reached agreement.