search

jenkins-x / enhancements

Repository containing design proposals for Jenkins X enhancements
12 stars 16 forks source link

feat: add decomposition proposal #31

Closed garethjevans closed 4 years ago

garethjevans commented 4 years ago

A proposal to start to decompose JX into a number of modules to make it more extensible.

cagiti commented 4 years ago

Great proposal 👍 👍

tdcox commented 4 years ago

Recommend looking at the architecture design first before refactoring or you may end up with a different shaped legacy problem. Versioning is critical to this sort of loose-coupling so this needs to consider https://github.com/jenkins-x/enhancements/issues/24 at the design stage.

garethjevans commented 4 years ago

Recommend looking at the architecture design first before refactoring or you may end up with a different shaped legacy problem. Versioning is critical to this sort of loose-coupling so this needs to consider #24 at the design stage.

@tdcox absolutely! This is the first of a number of proposals that we're expecting to produce to help get us to where we need to be. Ensuring these changes fit within the overall JX strategy is key - otherwise... what's the point!

deanesmith commented 4 years ago

It would be awesome to consider publishing architectural diagrams that describe the current state of things but also incorporate our longer-term ambitions with regards to decomposition. The most useful diagram type might bethe "physical model" as described here ( https://en.wikipedia.org/wiki/4%2B1_architectural_view_model ) but it shouldn't diminish the value of the other perspectives.

jenkins-x-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign jstrachan You can assign the PR to them by writing /assign @jstrachan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x/enhancements/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment