search

jenkins-x / jx-cdevents-adapter

CDEvents adapter for Jenkins X WIP
Apache License 2.0
2 stars 3 forks source link

Using other framework instead of Gorilla Mux #13

Open i-am-yuvi opened 1 year ago

i-am-yuvi commented 1 year ago

Is your proposal related to a problem?

We're using Gorilla Mux as http webframework which has very low performance. We can see here. Also Gorilla Mux project has been archived due to no active maintainer, which means there will be no future updates.

Describe the solution you'd like

I'ld like to suggest the use of Fiber which is very fast and has very low latency. The fiber can be easily understood by the new developers, also it has nice documentation. The composite benchmarks of fiber is far above than the gorilla/mux framework.

ankitm123 commented 1 year ago

Why not use something that is compatible with net/http? How about chi which is a pretty performant router and actively maintained. Fiber is good for very specific use cases, but the fact that it breaks compatibility with standard library makes it pretty unattractive to me.

Also if performance is an issue, we should measure it first in this repo before we seriously think about fiber.

i-am-yuvi commented 1 year ago

Yes, I think you're right. Since we're building a restful type API, chi would be better for building a scalable RESTful API and it is also compatible for net/http as well as standard library.

Should I go forward with chi?

ankitm123 commented 1 year ago

Yes, that would be awesome, thanks for looking into this :)