jx create quickstart --no-import doesn't run draft

davidcurrie commented 5 years ago

Summary

Running jx create quickstart --no-import only clones the quickstart. It doesn't set up git and it doesn't run draft.

Steps to reproduce the behavior

$ jx create quickstart --no-import
Using Git provider GitHub at https://github.com
? Git user name? davidcurrie

About to create repository  on server https://github.com with user davidcurrie
? Which organisation do you want to use? davidcurrie-org
? Enter the new repository name:  test

Creating repository davidcurrie-org/test
? select the quickstart you wish to create golang-http
Generated quickstart at /Users/dcurrie/code/src/github.com/davidcurrie-org/test
### NO charts folder /Users/dcurrie/code/src/github.com/davidcurrie-org/test/charts/golang-http
Created project at /Users/dcurrie/code/src/github.com/davidcurrie-org/test

$ ls test
Makefile    README.md   curlloop.sh main.go     watch.sh

Expected behavior

My expectation (perhaps incorrect) was this it would do everything but the pipeline setup.

Actual behavior

Command does nothing but the clone.

Jx version

The output of jx version is:

jx version
NAME               VERSION
jx                 1.3.841
jenkins x platform 0.0.3321
Kubernetes cluster v1.11.5-gke.5
kubectl            v1.12.0
helm client        v2.11.0+g2e55dbe
helm server        v2.12.2+g7d2b0c7
git                git version 2.18.0
Operating System   Mac OS X 10.14.2 build 18C54

Jenkins type

[ ] Classic Jenkins
[x] Serverless Jenkins

Kubernetes cluster

GKE

Operating system / Environment

MacOS

ccojocar commented 5 years ago

draft is only executed by the import command, which is invoked from create quickstart. The no-import option disables entire the import command.

ccojocar commented 5 years ago

@davidcurrie Can we close this issue, or are you interested to have the requested behaviour?

jenkins-x-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://jenkins-x.io/community. /lifecycle stale

davidcurrie commented 5 years ago

I have no personal requirement for this but my expectation is that --no-import would just prevent the project being added to Jenkins X but should otherwise generate the same files. If there's no particular interest in promoting jx create quickstart as a tool for generating best practice projects regardless of whether they are then going to be built/deployed with Jenkins X then this can be closed.

jenkins-x-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://jenkins-x.io/community. /lifecycle rotten

jenkins-x-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten. Provide feedback via https://jenkins-x.io/community. /close

jenkins-x-bot commented 5 years ago

@jenkins-x-bot: Closing this issue.

In response to [this](https://github.com/jenkins-x/jx/issues/3012#issuecomment-517981469): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. >Provide feedback via https://jenkins-x.io/community. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

jenkins-x / jx