search

jenkins-x / jx

Jenkins X provides automated CI+CD for Kubernetes with Preview Environments on Pull Requests using Cloud Native pipelines from Tekton
https://jenkins-x.io/
Apache License 2.0
4.58k stars 788 forks source link

Make Github webhook domain name configurable #6429

Closed tycoonm closed 4 years ago

tycoonm commented 4 years ago

Summary

I've deployed jx on to on-premise kubernetes cluster. All the application receive autoDNS domains. Everything is fine except github webhook. All the time when I add new project, I need to correct webhook address.

Steps to reproduce the behavior

Create on-premise kubernetes cluster and import some application. Check in repository of the application whether address with autoDNS domain is used as Payload URL.

Expected behavior

Github webhook Payload URL has some previously configured domain instead of autoDNS domain.

Actual behavior

Github webhook Payload URL has autoDNS domain

Jx version

The output of jx version is:

$ jx version
NAME               VERSION
jx                 2.0.1103
Kubernetes cluster v1.17.0
kubectl            v1.17.0
helm client        Client: v2.16.1+gbbdfe5e
git                2.21.0 (Apple Git-122.2)
Operating System   Mac OS X 10.14.6 build 18G103

verifying packages

Jenkins type

Kubernetes cluster

On-Premise

Operating system / Environment

Mac OS X 10.14.6 build 18G103

jenkins-x-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://jenkins-x.io/community. /lifecycle stale

jenkins-x-bot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://jenkins-x.io/community. /lifecycle rotten

jenkins-x-bot commented 4 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten. Provide feedback via https://jenkins-x.io/community. /close

jenkins-x-bot commented 4 years ago

@jenkins-x-bot: Closing this issue.

In response to [this](https://github.com/jenkins-x/jx/issues/6429#issuecomment-643322302): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. >Provide feedback via https://jenkins-x.io/community. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.