jenkins-x / jx

Jenkins X provides automated CI+CD for Kubernetes with Preview Environments on Pull Requests using Cloud Native pipelines from Tekton
https://jenkins-x.io/
Apache License 2.0
4.58k stars 788 forks source link

secrets for Amazon secrets manager ASM get double set of keys #8573

Open babadofar opened 1 year ago

babadofar commented 1 year ago

Somehow the updating of secrets in ASM never worked on my cluster due to missing permissions, Now the permissions were fixed and the secrets are botched. The secrets now get an extra key, like this

oauth: {"oauth": "ghp_kkkke"}

while the expectation is that the secret should be like

{"oauth": "ghp_kkkke"}
babadofar commented 1 year ago

@ankitm123 @msvticket do you see this problem as well?

msvticket commented 1 year ago

We don't use ASM

I had other problems when trying to use it so I reverted to vault

babadofar commented 1 year ago

Got this fixed now. First I saw that the AWS assumed role did not have permissions to update secrets. Fixed by adding the needed permissions to the role. Then by running "jx secret populate", the secrets were generated again, and now it works

msvticket commented 1 year ago

/area secrets