search

jenkins-x / jx

Jenkins X provides automated CI+CD for Kubernetes with Preview Environments on Pull Requests using Cloud Native pipelines from Tekton
https://jenkins-x.io/
Apache License 2.0
4.54k stars 784 forks source link

chore(deps): upgrade jenkins-x-plugins/jx-gitops to version 0.18.3 #8663

Closed JordanGoasdoue closed 1 month ago

JordanGoasdoue commented 2 months ago

related to https://github.com/jenkins-x-plugins/jx-gitops/pull/956

jenkins-x-bot commented 2 months ago

Hi @JordanGoasdoue. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
tomhobson commented 2 months ago

/ok-to-test /lgtm

jenkins-x-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x/jx/blob/main/OWNERS)~~ [tomhobson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msvticket commented 1 month ago

/override codecov/project

jenkins-x-bot commented 1 month ago

@msvticket: Overrode contexts on behalf of msvticket: codecov/project

In response to [this](https://github.com/jenkins-x/jx/pull/8663#issuecomment-2112378490): >/override codecov/project Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
msvticket commented 1 month ago

The problem is that the release pipeline of jx-gitops failed, so there are no binaries built. From the attempted build of 0.18.3:


    1s  Showing logs for build jenkins-x-plugins/jx-gitops/main #59 stage jx-pipeline-release and container step-upload-binaries
        The following paths are ignored by one of your .gitignore files:
        build
        changelog.md
        docker-credential-acr-env
        docker-credential-ecr-login
        docker-credential-gcr
        sbom.json
        hint: Use -f if you really want to add them.
        hint: Turn this message off by running
        hint: "git config advice.addIgnoredFile false"
        The following paths are ignored by one of your .gitignore files:
        build
        changelog.md
        docker-credential-acr-env
        docker-credential-ecr-login
        docker-credential-gcr
        sbom.json
        hint: Use -f if you really want to add them.
        hint: Turn this message off by running
        hint: "git config advice.addIgnoredFile false"
        [main 9d820853] chore: release 0.18.3
        Updated tag 'v0.18.3' (was bb9f2d24)
        To https://github.com/jenkins-x-plugins/jx-gitops.git
         + bb9f2d24...308d6f88 v0.18.3 -> v0.18.3 (forced update)
          • starting release...
          • loading config file                              file=.goreleaser.yml
          • loading environment variables
          • getting and validating git state
            • building...                                    commit=9d8208535e06284a77c8a40fabd9181625580112 latest tag=v0.18.3
          • parsing tag
          • setting defaults
          • running before hooks
            • running                                        hook=go mod download
          ⨯ release failed after 0s                  error=hook failed: go mod download: exit status 1; output: go: errors parsing go.mod:
        /workspace/source/go.mod:298: invalid go version '1.22.1': must match format 1.23
JordanGoasdoue commented 1 month ago

@msvticket thanks for the feedback => so i've done this PR => https://github.com/jenkins-x-plugins/jx-gitops/pull/961

I keep 1.22 here to be sure it doesn't break anything