Closed Skisocks closed 3 weeks ago
Hi @Skisocks. Thanks for your PR.
I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/cc @msvticket @tomhobson
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: tomhobson
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold
/test pr
/hold cancel
Linter pipeline has started failing as
service.golangci-lint-version
is no longer honoured so errors were being returned when trying to run deprecated linters. See linter failing here https://github.com/jenkins-x/jx/pull/8676This PR removes these deprecations and updates each linters config to the latest versions (finding equivalents if possible). Unused args have also been removed as per
revive
linter.