jenkins-x / lighthouse

Apache License 2.0
185 stars 115 forks source link

Added restartPolicy for keeper #1524

Closed OhTanishJain closed 1 year ago

OhTanishJain commented 1 year ago

Keeper Pod Readiness and Liveness is failing when pod got restarted. So, we wanted to give keeper ability to controlling restart.

jenkins-x-bot commented 1 year ago

Hi @OhTanishJain. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
jenkins-x-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign tomhobson You can assign the PR to them by writing /assign @tomhobson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x/lighthouse/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
OhTanishJain commented 1 year ago

/assign @tomhobson

tomhobson commented 1 year ago

/ok-to-test

OhTanishJain commented 1 year ago

Hey Tom,

I am facing one issue in Keeper pod. Readiness and Liveness probe are failing, due to this pod goes down and Pr's are not auto merge. Could you please give some advice on this?

On Fri, 14 Apr 2023, 13:49 Tom Hobson, @.***> wrote:

/ok-to-test

— Reply to this email directly, view it on GitHub https://github.com/jenkins-x/lighthouse/pull/1524#issuecomment-1508122311, or unsubscribe https://github.com/notifications/unsubscribe-auth/AT6RLMROEZRHJAT2KYJNKKTXBECCLANCNFSM6AAAAAAV2DNVJE . You are receiving this because you were mentioned.Message ID: @.***>

tomhobson commented 1 year ago

Hey @OhTanishJain, maybe not the right place to ask about this issue. It sounds like a larger underlying issue that this wont actually resolve.

What response do you get from the errors logs? It might be worth joining us in the kubernetes slack channel in the #jenkins-x-user area and we can talk through and hopefully resolve your problem. Thanks.

tomhobson commented 1 year ago

Should I close this with the above in mind?

OhTanishJain commented 1 year ago

Sure. I'll ping you in the channel