search

jenkins-x / lighthouse

Apache License 2.0
185 stars 115 forks source link

feat: update cronjob version for lighthouse #1537

Closed tomhobson closed 1 year ago

tomhobson commented 1 year ago

Going to go through the jenkins-x objects to get them ready for an upgrade


NAME                                                              KIND                      VERSION               REPLACEMENT      REMOVED   DEPRECATED   REPL AVAIL
lighthouse-gc-jobs                                                CronJob                   batch/v1beta1         batch/v1         false     true         true
tomhobson commented 1 year ago

/cc @msvticket @babadofar @ankitm123

jenkins-x-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign tomhobson You can assign the PR to them by writing /assign @tomhobson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x/lighthouse/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
babadofar commented 1 year ago

https://github.com/jenkins-x/jx/issues/8454

tomhobson commented 1 year ago

If lighthouse is committed to support v1.25 of Kubernetes, then this change is required.

@davidrmcgee hey, I closed this as it was done in another PR. The latest version of lighthouse should support this now :)

https://github.com/jenkins-x/lighthouse/blob/main/charts/lighthouse/templates/gc-jobs-cj.yaml