feat: trigger on deploy status and periodically

[jenkins-x-bot]

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated. We'll continue to update you through PRs as we progress. Please check #8589 for further information.

[msvticket]

Tests require jenkins-x/go-scm#404 to be merged

[tomhobson]

@msvticket how we getting on with this? Need an assist or anything?

[msvticket]

@msvticket how we getting on with this? Need an assist or anything?

I still have some unit tests to implement. Some tests for periodics are implemented, but none for deployment. Also I haven't done any manual tests yet.

Some documentation would be generated automatically, but some more should be written I guess.

So you could work on tests and docs... But I'll get to it eventually.

[msvticket]

/test pr

[msvticket]

/test pr

[msvticket]

/retest

[msvticket]

I have now gotten so far that I have started testing this in my own cluster. Triggering on deployment works. Here is a screen shot from my pipeline dashboard showing a pipelinerun for a release and then a deployment:

As for periodic triggers the scan and initialization for existing periodic triggers does not work; I don't think that is a merge stopper though since I put that behind a feature toggle. I will now test that adding a periodic trigger works.

[msvticket]

/retest

[msvticket]

/test pr

[msvticket]

/retest

[msvticket]

/retest

[msvticket]

/cc @tomhobson

Now I have tested periodics as well and they run. But as mentioned above the scan and initialization for existing periodic triggers does not work; I don't think that is a merge stopper though since I put that behind a feature toggle. Also I noticed that execution of periodic triggers doesn't show up in the dashboard; I haven't checked why.

All in all this is not perfect, but I think it is good enough to merge.

[msvticket]

/test pr

[tomhobson]

a m a z i n g

been waiting for this for so long, never had time to get it done

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x/lighthouse/blob/main/OWNERS)~~ [tomhobson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

[jenkins-x-bot]

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]