search

jenkins-x / lighthouse

Apache License 2.0
184 stars 115 forks source link

feat: add source to lighthouse api #1571

Closed rochana-atapattu closed 8 months ago

rochana-atapattu commented 1 year ago

this change passes the sourcepath for the triggerconfig down to lighthousespec. with this change we can facilitate addition of new agents (engines), using the value in source to trigger pipelines of their own.

jenkins-x-bot commented 1 year ago

Hi @rochana-atapattu. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
jenkins-x-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign garethjevans You can assign the PR to them by writing /assign @garethjevans in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/jenkins-x/lighthouse/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msvticket commented 9 months ago

this change passes the sourcepath for the triggerconfig down to lighthousespec. with this change we can facilitate addition of new agents (engines), using the value in source to trigger pipelines of their own.

Can you describe in a bit more detail how you envision this to be used?

msvticket commented 8 months ago

PR is adandoned by developer