jenkins-x / lighthouse

Apache License 2.0
183 stars 114 forks source link

fix: get the baseRefSha from graphql to reduce rate consumption #1580

Closed Skisocks closed 10 months ago

Skisocks commented 10 months ago

We can get the pull requests baseRefSha from the graphql query, this should reduce the rate limit usage as we no longer need to hit the rest api for every PR returned by the initial graphql query. This also reduces the rate consumption for scms that don't support graphql as baseRefSha is already found in the initial rest query.

jenkins-x-bot commented 10 months ago

Hi @Skisocks. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [jenkins-x/lighthouse](https://github.com/jenkins-x/lighthouse/issues/new?title=Command%20issue:) repository.
Skisocks commented 10 months ago

/cc @tomhobson @msvticket

msvticket commented 10 months ago

/ok-to-test

jenkins-x-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jenkins-x/lighthouse/blob/main/OWNERS)~~ [msvticket] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]

jenkins-x-bot commented 10 months ago

Failed to merge this PR due to:

failed merging [1580]: [Method Not Allowed]